search

blaze / odo

Data Migration for the Blaze Project
http://odo.readthedocs.org/
BSD 3-Clause "New" or "Revised" License
1.01k stars 138 forks source link

Microsoft SQL Server bcp import/export #575

Closed n0mn0m closed 6 years ago

n0mn0m commented 7 years ago

Added bcp functionality for odo within the framework of the other copy to/from flat file loaders. Tried to cover kwarg support for items like delimiter and newline settings. Using popen so that any error can be captured and populated. OSError will provide an error if bcp is not installed. One concern I have is building the Server.Database.Schema information. Currently I did this by slicing up the connection string that is given to sqlalchemy into a dict because I didn't see the server/db information in the element. Any feedback on a better way to accomplish retrieving that data that could be more stable would be appreciated.

majidaldo commented 6 years ago

@AlexHagerman do you have tests?

n0mn0m commented 6 years ago

I don't have any test. At the time I wrote this I wasn't as familiar with Python test frameworks. I've since made some progress if this is something anybody wants I can look into what mocks or fixtures would help facilitate testing bcp with Pytest. Since bcp is from a flat file I'd be open to suggestions on any fixtures that might make sense. Also not sure what SQL Server integration testing there is in the travis build if any.

nickolay commented 6 years ago

There's some discussion of bulk-loading in https://github.com/blaze/odo/issues/571 and another attempt at adding bcp functionality among other things in https://github.com/blaze/odo/pull/525