blazegraph / database

Blazegraph High Performance Graph Database
GNU General Public License v2.0
891 stars 172 forks source link

Upgrade to more recent Sesame version #110

Open smalyshev opened 5 years ago

smalyshev commented 5 years ago

Partially the same as https://github.com/blazegraph/database/issues/40, but I tried to upgrade to 2.9.0 or 2.8.x of Sesame (which may be intermediary step before migrating to RDF4J) and I have these issues:

[ERROR] /Users/smalyshev/blazegraph/bigdata-client/src/main/java/com/bigdata/rdf/sail/remote/BigdataSailRemoteRepositoryConnection.java:[106,7] error: BigdataSailRemoteRepositoryConnection is not abstract and does not override abstract method begin(IsolationLevel) in RepositoryConnection

Looks like there's new begin() method which needs to be overridden. Also:

[ERROR] /Users/smalyshev/blazegraph/bigdata-client/src/main/java/com/bigdata/rdf/sail/remote/BigdataSailRemoteRepositoryConnection.java:[755,23] error: <anonymous com.bigdata.rdf.sail.remote.BigdataSailRemoteRepositoryConnection$3> is not abstract and does not override abstract method getMaxExecutionTime() in Operation

Looks like Operation gained new setMaxExecutionTime() method which needs to be overridden.

[ERROR] /Users/smalyshev/blazegraph/bigdata-client/src/main/java/com/bigdata/rdf/sail/remote/AbstractBigdataRemoteQuery.java:[30,6] error: cannot find symbol
[ERROR] symbol:   variable maxQueryTime
[ERROR] location: class AbstractBigdataRemoteQuery
[ERROR] /Users/smalyshev/blazegraph/bigdata-client/src/main/java/com/bigdata/rdf/sail/remote/AbstractBigdataRemoteQuery.java:[31,86] error: cannot find symbol

And also TurtleParser does not export read() method anymore, which breaks SPARQLUpdateDataBlockParser and other classes maybe. Probably readCodePoint() can be used instead.

Would appreciate any suggestions about how to make it upgradable to more recent Sesame version - there are some bugfixes that I'd like to take advantage of.

smalyshev commented 5 years ago

Commit https://github.com/wikimedia/wikidata-query-blazegraph/commit/b03e93016eef5a97799235c4cf8808b206b52d12 implements the upgrade.