search

blazegraph / database

Blazegraph High Performance Graph Database
GNU General Public License v2.0
873 stars 170 forks source link

BLZG-9160: Upgrade to Sesame 2.8.11 #112

Closed smalyshev closed 5 years ago

smalyshev commented 5 years ago

Followup to https://github.com/blazegraph/database/issues/110 - would appreciate the review.

thompsonbry commented 5 years ago

We try to mark the OpenRDF files with an @openrdf annotation. Any files marked like that are blazegraph specific overrides of the corresponding openrdf files. Those files need to be reviewed when changing versions.

Did brad set you up with CI yet? If so, do you have a CI run for this CR?

Do you have a summary of the changes between 2.7 and 2.8? I am trying to recall what the new features are and whether any of them would likely cause problems.

Bryan

On Wed, Dec 12, 2018 at 16:22 Stanislav Malyshev notifications@github.com wrote:

Followup to #110 https://github.com/blazegraph/database/issues/110 - would appreciate the review.

You can view, comment on, or merge this pull request online at:

https://github.com/blazegraph/database/pull/112 Commit Summary

  • Upgrade to Sesame 2.8.11

File Changes

Patch Links:

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/blazegraph/database/pull/112, or mute the thread https://github.com/notifications/unsubscribe-auth/ACdv4A1gA7tv0BkmgYsALRWIQLf2tgtxks5u4Z3TgaJpZM4ZQsiw .

thompsonbry commented 5 years ago

Blazegraph supports snapshot isolation. It does not support any other isolation level (no dirty reads, etc.). If an unsupported isolation level is requested, then consult the open RDF docs for the correct response.

smalyshev commented 5 years ago

The motivation is mainly bugfixes. E.g. this one: https://phabricator.wikimedia.org/T200612 was fixed in 2.8.0 but I imagine there were more bugs fixed since 2013...

thompsonbry commented 5 years ago

Yes, just remember the value and report it back.

It would/could be used (perhaps) in marshaling the query to the remote endpoint.

On Mon, Dec 17, 2018 at 00:33 Stanislav Malyshev notifications@github.com wrote:

@smalyshev commented on this pull request.

In bigdata-client/src/main/java/com/bigdata/rdf/sail/remote/BigdataSailRemoteRepositoryConnection.java https://github.com/blazegraph/database/pull/112#discussion_r242058309:

@@ -797,7 +798,17 @@ public void setDataset(Dataset arg0) { public boolean getIncludeInferred() { throw new UnsupportedOperationException(); }

+

  • @Override
  • public void setMaxExecutionTime(int i) {

But to implement the interface I need to provide some implementation for these methods. Should it just remember the parameter for setMaxExecutionTime() without doing anything? Because it doesn't look like there's implementation of any logic involving it anywhere.

— You are receiving this because you commented.

Reply to this email directly, view it on GitHub https://github.com/blazegraph/database/pull/112#discussion_r242058309, or mute the thread https://github.com/notifications/unsubscribe-auth/ACdv4EwAS563tzOgtQxDB1T7tAOpZUnVks5u51bygaJpZM4ZQsiw .