search

blazegraph / database

Blazegraph High Performance Graph Database
GNU General Public License v2.0
885 stars 171 forks source link

Please revise #67

Open chile12 opened 7 years ago

chile12 commented 7 years ago

Forwarding the keyset here: https://github.com/blazegraph/database/blob/master/bigdata-core/bigdata-rdf/src/java/com/bigdata/bop/rdf/join/ChunkedMaterializationOp.java#L396

does not go over well with adding something to it here: https://github.com/blazegraph/database/blob/master/bigdata-core/bigdata-rdf/src/java/com/bigdata/rdf/lexicon/LexiconRelation.java#L2743

Which will result in an UnsupportedOperationException, as it does in my case.

thompsonbry commented 7 years ago

What JVM version? Can you include a unit test a file a ticket on JIRA?

Thanks, Bryan

On Fri, Jul 14, 2017 at 2:46 AM, Markus Freudenberg < notifications@github.com> wrote:

Forwarding the keyset here: https://github.com/blazegraph/database/blob/master/bigdata- core/bigdata-rdf/src/java/com/bigdata/bop/rdf/join/ ChunkedMaterializationOp.java#L396

does not go over well with adding something to it here: https://github.com/blazegraph/database/blob/master/bigdata- core/bigdata-rdf/src/java/com/bigdata/rdf/lexicon/ LexiconRelation.java#L2743

Which will result in an UnsupportedOperationException, as it does in my case.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/blazegraph/database/issues/67, or mute the thread https://github.com/notifications/unsubscribe-auth/ACdv4KcxKRixbKC_l2_ZZBqwxY3ouCl9ks5sNzjfgaJpZM4OYDAa .

chile12 commented 7 years ago

1: openjdk version "1.8.0_131" OpenJDK Runtime Environment (build 1.8.0_131-8u131-b11-0ubuntu1.16.10.2-b11) OpenJDK 64-Bit Server VM (build 25.131-b11, mixed mode)

2: no, but adding all members of unrequestedSidTerms and ivs (the forwarded Set) in a new Set instead of adding all of unrequestedSidTerms into ivs, solved that issue for me. Changing the keyset can trigger all manner of side effects. Since you are removing the added keys later in the same method, consider changing this: https://github.com/blazegraph/database/blob/master/bigdata-core/bigdata-rdf/src/java/com/bigdata/rdf/lexicon/LexiconRelation.java#L2899

beebs-systap commented 7 years ago

See also BLZG-9000.