search

blazeworx / flagstrap

A lightwieght jQuery plugin for creating Bootstrap 3 compatible country select boxes with flags
http://blazeworx.github.io/flagstrap
MIT License
88 stars 62 forks source link

[BUG] Added a click event to the generated button… #36

Open sjoller opened 5 years ago

sjoller commented 5 years ago

… and a toggle() on the OL list when an item is clicked. Minor other changes, like switching all 'var's to, the ES6 standard, 'let' is also added.

For some reason there was no events registered to the generated button - at first I thought i might be an issue with versions of jQuery (the demo site is using jQuery v1.11.2, and I'm on v3.2.1), but looking at the source, there was no events registered. Unless there's an inconsistency from the source to the minified source, it's beyond me how this actually work on the demo site...

sjoller commented 5 years ago

Hi,

I don't mind making a pull request, but I've taken my fork way beyond a single PR, at this point. We had specific needs in our project, so it's pretty much tailored to that - you might not want it all merged in.

Let me know if you're still interested.