search

blazium-engine / blazium

Blazium Engine – Multi-platform 2D and 3D game engine
https://blazium.app/
MIT License
149 stars 19 forks source link

Add new `FoldableContainer` node. #77

Closed WhalesState closed 2 days ago

WhalesState commented 3 days ago

https://github.com/user-attachments/assets/fe3e0d3e-47b4-4562-ad26-8738c3dc604b

Starkium commented 2 days ago

This is cool, does it make sense to go into the engine and not a plugin or ui pack?

RandomOfNoWhere commented 2 days ago

This would be really useful for GUIs that have an assortment of overlays like in some MMORPGs.

Is there a way to 'X' out the box? I could have just missed it but don't see one.

WhalesState commented 2 days ago

This is cool, does it make sense to go into the engine and not a plugin or ui pack?

Editor: It can be used for EditorSettings, ProjectSettings and also it can replace the EditorInspector sections, also it will be useful for editor plugins.

Game: It can be used for Game Settings.

Why it's not a plugin? Because we can't bind theme constants, theming support for custom classes is poor.

passivestar: A foldable container in core would be useful to have for editor plugins, because it will make foldable sections in third-party plugins have the same default look and behaviour as the built-in inspector foldables, making the UX more consistent throughout the editor.

Also i think Unity Gui has this in core.

WhalesState commented 2 days ago

Is there a way to 'X' out the box? I could have just missed it but don't see one.

what do you mean by 'X' ? collapse ?

RandomOfNoWhere commented 2 days ago

Sorry, still waking up this morning.... to close out the FoldAbleContainer (No I don't want it in the opposite corner just an example) npJGRnK

Starkium commented 2 days ago

Other than potentially updating the copyright, code seems fine. I think the feature is a good idea, so long as there is no other similar thing. There are already collapsible areas in the editor UI. Forgive me for not immediately noticing, getting morning coffee in me, but what is the difference?

WhalesState commented 2 days ago

Other than potentially updating the copyright, code seems fine. I think the feature is a good idea, so long as there is no other similar thing. There are already collapsible areas in the editor UI. Forgive me for not immediately noticing, getting morning coffee in me, but what is the difference?

The EditorInspectorSection is very useful for the ObjectInspector, but it's an editor only class, so users can's use it when they create an inspector or editor settings for apps or modding tools, it can organize any menu like node, making it more readable by grouping control nodes together.

Bioblaze commented 2 days ago

Other than potentially updating the copyright, code seems fine. I think the feature is a good idea, so long as there is no other similar thing. There are already collapsible areas in the editor UI. Forgive me for not immediately noticing, getting morning coffee in me, but what is the difference?

no need to update the copyright as of now. Just too much extra work for not enough value.

Starkium commented 2 days ago

well looks good to me then, I'll merge it