Preset loading issue with 2D

Shaps-77 commented 2 years ago

What happened?

When using a macro button to scroll presets, they scroll correctly in UI but the LED output is unchanged. If a preset button is 'directly' pressed in UI, the preset loads correctly and LED output is as expected.

To Reproduce Bug

Setup multiple presets with differing lighting effects (eg. 1-5 in my case) Create a macro to scroll presets win&P1=1&P5=30&PL=~

Expected Behavior

LED output should change in line with UI

Install Method

Self-Compiled

What version of WLED?

WLED 0.14.0-bl0 (build 2205251)

Which microcontroller/board are you seeing the problem on?

ESP32

Relevant log/trace output

No response

Anything else?

Thank you :)

Code of Conduct

[X] I agree to follow this project's Code of Conduct

blazoncek commented 2 years ago

This only happens with HTTP API preset that changes current presets. Known issue.

blazoncek commented 2 years ago

I think I have found the bug.

blazoncek commented 2 years ago

This 14887d5e88ca2c2107365f5d44cd8d9034b773f8 should fix it.

Shaps-77 commented 2 years ago

Quick test of functionality in conjunction with usermods

ROTARY_ENCODER_BRIGHTNESS_COLOR
PIRSWITCH and everything is working as expected.

I can't thank you enough Blaž 🙏🙌🍻

blazoncek / WLED