bldg14 / eventual

A simple event calendar
https://eventual-client.fly.dev
MIT License
0 stars 0 forks source link

Fly.io github action deploys are failing #39

Closed kevinfalting closed 11 months ago

kevinfalting commented 11 months ago

Issue Description

In #38, I changed the names of the apps we were using, along with adding one for the client.

Previously, there was a fly.toml with an app name of eventual. I had followed this guide in #36 running fly tokens create deploy -x 999999h and placing that in a FLY_API_TOKEN repository secret in github. This references the app name in the default fly.toml file and ties the token to that specific app. According to the Deploy Tokens reference, deploy tokens are limited to a single application.

Two things happened:

  1. I changed the name of the server, which the token was no longer valid for.
  2. I added the client as a deploy target. Deploy tokens can only be used with a single app.

The part that I don't know is if this will work, so we'll just need to merge to main and try it out.

Supporting Documentation

While I don't think this should stop us, fly.io is currently experiencing an outage: https://fly.io/dashboard/eventual/status

Implementation Details

I've already generated two new deploy tokens:

$ fly tokens create deploy --config ./fly.server.toml --name="flyctl deploy token eventual-server"
# [token redacted]
$ fly tokens create deploy --config ./fly.client.toml --name="flyctl deploy token eventual-client"
# [token redacted]

And then added them as repository secrets in this repo under FLY_API_TOKEN_EVENTUAL_SERVER and FLY_API_TOKEN_EVENTUAL_CLIENT respectively.

I suspect we can just reference these secrets in their respective deploy jobs.

Acceptance Criteria

kevinfalting commented 11 months ago

Looks like it worked! Closing.