search

bldg14 / eventual

A simple event calendar
https://eventual-client.fly.dev
MIT License
0 stars 0 forks source link

Kf/43 link client server in prod #44

Closed kevinfalting closed 11 months ago

kevinfalting commented 11 months ago

Overview

This PR allows the client to make requests across domains to the server.

Related Issues / PRs

Resolves: #18, #43

Thought Process

I've documented much of it in the related issues and as commit messages. Basically, the CORS policies set in the server's middleware were incorrect and were updated. A separate config for production was required, and the Dockerfiles were updated to accomodate these new configurations.

Testing Steps

Ensure that the client and server can communicate by running them both locally and opening up the browser console to see the events retrieved from the server.

I've already pushed both the server and client to production via flyctl, so if you open the browser console at https://eventual-client.fly.dev/ you'll see the events printed to the console from the server.

Risks

If a configuration was incorrect, CORS will block requests from being made to the server from the client.

vercel[bot] commented 11 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
eventual ✅ Ready (Inspect) Visit Preview Sep 17, 2023 6:13pm
kevinfalting commented 11 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC) eventual ✅ Ready (Inspect) Visit Preview Sep 17, 2023 6:13pm

Vercel deploys will not work until we setup the subdomain deploys, and I'm not entirely certain vercel is what we're going to use here. We're just trialing it for now.