box update

[cordoval]

some questions:

{
    "alias": "bldr.phar",
    "chmod": "0755",
    "compactors": [
        "Herrera\\Box\\Compactor\\Json",
        "Herrera\\Box\\Compactor\\Php"
    ],
    "files": [
        "LICENSE",
        "vendor/composer/installed.json",
        "vendor/dflydev/embedded-composer/.root_package.json"
    ],
    "finder": [
        {
            "name": [
                "LICENSE*",
                "License*",
                "*.php",
                "*.xml",
                "*.xsd",
                "*.yaml",
                "*.yml",
                "*.json"
            ],
            "notName": [
                "composer.json"
            ],
            "exclude": [
                "phpunit",
                "Tests",
                "tests"
            ],
            "in": ["bin", "src", "vendor"]
        }
    ],
    "extract": true,
    "git-commit": "git-commit",
    "git-version": "package_version",
    "main": "bin/bldr-phar-stub",
    "output": "bldr.phar",
    "stub": true
}

it seems also you use a custom stub, shouldn't that be rather in stub and not in main? why you extract true it? why you include licenses, and json installed files? isn't chmod 755 default? why making it explicit if so? what is the % of compactness differ when you use or not use the compactors?

[cryptiklemur]

1) not sure what you mean 2) That could probably be removed. 3) Licenses are required to be with the code, no matter where it is. And there were a couple of important json files iirc. 4) Explicit doesn't mean bad 5) not sure, but im not really worried about compactness.

[cordoval]

1) "main": "bin/bldr-phar-stub", instead of having

"stub": "bin/bldr-phar-stub",

3) important json files but i think they are just installed.json and some other not sure why they would be needed though

4) i agree

5) true it should not compress it that much but still useful, gushphp is not using it yet

[cryptiklemur]

1) again, not sure what you mean/are asking. 5) its really not that useful. PHP doesn't need to be compressed

[cordoval]

ok thanks for your answers. Closing now. :+1: