search

bldr-io / bldr

Awesome Task Runner
http://bldr.io
MIT License
219 stars 21 forks source link

Create a new tag 9.0.2, since 9.0.1 is buggy #152

Closed lastzero closed 8 years ago

lastzero commented 8 years ago

9.0.1 does not contain the fix I provided shortly after, see ae05fd5a98eb50c4c2143105026a916dee952b5d

lastzero commented 8 years ago

Is this project abandoned? Your latest release is broken and your tests are failing for months.

cryptiklemur commented 8 years ago

https://github.com/bldr-io/bldr/releases/tag/9.0.2

Nope, still working on it. Just haven't fixed the minor issues in the tests

lastzero commented 8 years ago

I just had the impression that if somebody would use this software on a daily basis, he/she would have noticed the bug in 9.0.1 as well as the issue I mentioned in #153. These are/were not minor issues.

cryptiklemur commented 8 years ago

This project is being used on a daily basis in many projects as a phar, and did not run into any issues with #153, nor the bug in 9.0.1.

lastzero commented 8 years ago

So the general advice is to use the phar and not include Bldr via composer as we did, since that is not tested by the developers on a daily basis.

cryptiklemur commented 8 years ago

The suggested install method is using a phar, and the only reasoning behind that is so you don't get dependency conflicts between bldr and your project.

lastzero commented 8 years ago

If you look again at #153, the version conflict was within Bldr and not related to any other project at all. Also, putting a phar (or any other external dependency) in a project's code repository is not considered a best practice. Established tools like phpunit and phing use composer for installation without major issues. Actually, a phar can cause more problems - just you look at this phpunit issue to see an example: https://github.com/sebastianbergmann/phpunit/issues/2015

cryptiklemur commented 8 years ago

Why is it not considered a best practice? Do you have any sources for that?

lastzero commented 8 years ago

https://getcomposer.org/doc/faqs/should-i-commit-the-dependencies-in-my-vendor-directory.md

cryptiklemur commented 8 years ago

That makes no mention of phar files.

lastzero commented 8 years ago

Right, you are allowed to make that connection yourself. A phar is nothing else that a dependency in a special file format.

cryptiklemur commented 8 years ago

And none of the issues mentioned in that article apply to a phar file.

I'm going to leave the suggested install method with Phar for now. Thank you for your input though.