bldrs-ai / Share

Share is a web-based BIM & CAD collaboration platform.
http://bldrs.ai
106 stars 31 forks source link

Refactor hash state system #1177

Closed pablo-mayrgundter closed 6 months ago

pablo-mayrgundter commented 6 months ago

Visual diff e2e tests

Full run: https://percy.io/8fe2b2f1/share/builds/34111775/changed/1867319070

After fixing 2 regressions, just ran those alone: https://percy.io/8fe2b2f1/share/builds/34111978/changed/1867332591

yarn install && yarn cy-build && yarn cy-percy cypress/e2e/open/100/open-model-from-gh-ui.cy.js cypress/e2e/view-100/cutplanes.cy.js
netlify[bot] commented 6 months ago

Deploy Preview for bldrs-share ready!

Name Link
Latest commit f43de0dbbd3d19c5073919297da2c77e344798d7
Latest deploy log https://app.netlify.com/sites/bldrs-share/deploys/663d127874f893000838db11
Deploy Preview https://deploy-preview-1177--bldrs-share.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

Lighthouse
1 paths audited
Performance: 17 (no change from production)
Accessibility: 91 (no change from production)
Best Practices: 92 (no change from production)
SEO: 100 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] commented 6 months ago

Deploy Preview for bldrs-share-v2 ready!

Name Link
Latest commit f43de0dbbd3d19c5073919297da2c77e344798d7
Latest deploy log https://app.netlify.com/sites/bldrs-share-v2/deploys/663d1278295ef40008e6d063
Deploy Preview https://deploy-preview-1177--bldrs-share-v2.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

pablo-mayrgundter commented 6 months ago

Addressed all

Percy diffs https://percy.io/8fe2b2f1/share/builds/34130461

OlegMoshkovich commented 6 months ago

Love the search and imagine improvements! It is all working but the notes issues, it still do not reset when a note is selected and a new model is loaded.

OlegMoshkovich commented 6 months ago

Approved. This is still happening, even though the hash is reset when a new model is loaded. 2 Notes Hash Issue: When a specific note is selected and a new model is loaded into the session the notes do not navigate to the notes list

Steps to Reproduce:

Select a note on the home screen. Switch to Momentum Observed Behavior: The side - drawer displays an empty drawer. Expected Behavior: The side - drawer should update to show a list of notes from the newly loaded model.

image
sentry-io[bot] commented 6 months ago

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

Did you find this useful? React with a 👍 or 👎