Closed pablo-mayrgundter closed 6 months ago
Name | Link |
---|---|
Latest commit | f43de0dbbd3d19c5073919297da2c77e344798d7 |
Latest deploy log | https://app.netlify.com/sites/bldrs-share/deploys/663d127874f893000838db11 |
Deploy Preview | https://deploy-preview-1177--bldrs-share.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
Lighthouse |
1 paths audited Performance: 17 (no change from production) Accessibility: 91 (no change from production) Best Practices: 92 (no change from production) SEO: 100 (no change from production) PWA: - View the detailed breakdown and full score reports |
To edit notification comments on pull requests, go to your Netlify site configuration.
Name | Link |
---|---|
Latest commit | f43de0dbbd3d19c5073919297da2c77e344798d7 |
Latest deploy log | https://app.netlify.com/sites/bldrs-share-v2/deploys/663d1278295ef40008e6d063 |
Deploy Preview | https://deploy-preview-1177--bldrs-share-v2.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
Addressed all
Percy diffs https://percy.io/8fe2b2f1/share/builds/34130461
Love the search and imagine improvements! It is all working but the notes issues, it still do not reset when a note is selected and a new model is loaded.
Approved. This is still happening, even though the hash is reset when a new model is loaded. 2 Notes Hash Issue: When a specific note is selected and a new model is loaded into the session the notes do not navigate to the notes list
Steps to Reproduce:
Select a note on the home screen. Switch to Momentum Observed Behavior: The side - drawer displays an empty drawer. Expected Behavior: The side - drawer should update to show a list of notes from the newly loaded model.
This pull request was deployed and Sentry observed the following issues:
removeHashParams(src/utils/location)
View IssueremoveHashParams(src/utils/location)
View IssueDid you find this useful? React with a 👍 or 👎
AboutDialog not visible, model visible - Screen
, so the bug is indeed transient and I don't think I can add any new test for itHASH_PREFIX_<component name>
variable in ahashState.js
file in its directoryvp
tocp
. Maybe should becut
?Visual diff e2e tests
Full run: https://percy.io/8fe2b2f1/share/builds/34111775/changed/1867319070
After fixing 2 regressions, just ran those alone: https://percy.io/8fe2b2f1/share/builds/34111978/changed/1867332591