bldrs-ai / Share

Share is a web-based BIM & CAD collaboration platform.

http://bldrs.ai

106 stars 31 forks source link

Closed OlegMoshkovich closed 5 months ago

OlegMoshkovich commented 5 months ago

This PR:

Sets the width of the search bar to match the width of other panels.
Adds an adornment to the TextField component of the search bar to clear the input, ensuring the search string does not overlap with the clear icon.
Sets the search TextField to multiline to accommodate long GitHub strings.
Moves the versions panel to the same location as the nav tree panel.

Updated

netlify[bot] commented 5 months ago

Name	Link
Latest commit	2e7b7417f0497d40d9d571abf9664421c1aad0ef

netlify[bot] commented 5 months ago

Name	Link
Latest commit	aafc39bb5a9a3d7767231bd771af0050b9a9e421
Latest deploy log	https://app.netlify.com/sites/bldrs-share/deploys/666c6ca24250f1000844f3fb
Deploy Preview	https://deploy-preview-1208--bldrs-share.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 17 (no change from production) Accessibility: 91 (no change from production) Best Practices: 92 (no change from production) SEO: 100 (no change from production) PWA: - View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

pablo-mayrgundter commented 5 months ago

I don't see any changes to search in Percy. Shouldn't we see them in the search-100 tests?

pablo-mayrgundter commented 5 months ago

Oh whoops, I do see it. But also a flake. Can you add waits for those to deflake?

This is the intended change:

These are the flakes:

OlegMoshkovich commented 5 months ago

@pablo-mayrgundter notes tests should not be a part of this PR. It should be addressed separately, will create a ticket. Issue: https://github.com/bldrs-ai/Share/issues/1216

Updated percy run - PTAL