search

bldrs-ai / Share

Share is a web-based BIM & CAD collaboration platform.
http://bldrs.ai
103 stars 30 forks source link

Disable nav tree activation on the element select #1239

Closed OlegMoshkovich closed 1 month ago

OlegMoshkovich commented 1 month ago

1238

percy

netlify[bot] commented 1 month ago

Deploy Preview for bldrs-share ready!

Name Link
Latest commit 4feb149f27edfc0ee9afe7a0ebe4a967af2bd657
Latest deploy log https://app.netlify.com/sites/bldrs-share/deploys/66a0ea8fe297d9000832f6fe
Deploy Preview https://deploy-preview-1239--bldrs-share.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

Lighthouse		 1 paths audited
Performance: 17 (no change from production)
Accessibility: 91 (no change from production)
Best Practices: 92 (no change from production)
SEO: 100 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

OlegMoshkovich commented 1 month ago

@pablo-mayrgundter PTAL

OlegMoshkovich commented 1 month ago

Unit Testing: A NavControl test has been added to validate the interaction of the nav control button. Since this PR changes the opening of the nav panel based on the selected element, the test checks if the nav visibility state variable remains false when the element is selected, and if the nav visibility switches to true when the control button is pressed.

End-to-End Test: The View 100 - Item highlighted in scene - Screen has been adjusted.

Percy build requires approval.

OlegMoshkovich commented 1 month ago

@pablo-mayrgundter PTAL