bldrs-ai / Share

Share is a web-based BIM & CAD collaboration platform.
http://bldrs.ai
105 stars 31 forks source link

System: FE: Poor UI component interaction speed with large models #239

Open MarkusSteinbrecher opened 2 years ago

MarkusSteinbrecher commented 2 years ago

The performance with large models is currently not what the user expects. The frame rate is low when rotating the model and clicking an element takes multiple seconds to update (while the screen is frozen). Information on properties takes multiple minutes to load.

Tested with this model: https://drive.google.com/file/d/1-5Ufg8PmDTr6GFGzOLQcgK6SM2jn_Vm-/view?usp=sharing

pablo-mayrgundter commented 2 years ago

Can we publish this model? With the LFS fix we should be able to serve it in prod

OlegMoshkovich commented 2 years ago

@pablo-mayrgundter This is great a starting point - but I feel that in order for it to be an issue - we need to hash it out further. can I close for now?

MarkusSteinbrecher commented 2 years ago

You mean the issue description needs more detail?

OlegMoshkovich commented 2 years ago

I think optimization of Large models will touch many parts of the system, and at some point when we are ready for this work, mode detailed issue list will emerge out of design/discussion.

pablo-mayrgundter commented 2 years ago

I think there's 2 parts to the slowness:

I don't think we'll do much about framerate in the near-term, but I also think Markus is more sensitive about this than your average user! ;)

I read this as UI component responsiveness, and it does take time to select items in the UI. We should work on this. I think this scope is fine. I'll reword the title and @MarkusSteinbrecher, please try a large model again and see if framerate is still low. If so please open a separate bug for that.

MarkusSteinbrecher commented 2 years ago

well if you give me WASD I need at least 120 fps ;)

MarkusSteinbrecher commented 2 years ago

I think it should be on publig github already:

https://github.com/Swiss-Property-AG/Seestrasse-Public

-- swiss property AG Giesshübelstrasse 62D CH-8045 Zurich swiss-property.ch

Am 25.06.2022 um 12:34 schrieb Pablo Mayrgundter @.***>:

 Can we publish this model? With the LFS fix we should be able to serve it in prod

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread.

OlegMoshkovich commented 1 year ago

Another Example of the slowness is trying to select an element on this model https://bldrs.ai/share/v/gh/Swiss-Property-AG/Turmfalke-Public/main/TURMFALKE.ifc/88/111/138/1898885/1916909#p:y=2.3394265647800356::c:19.31,20,-14.82,2.55,8.47,5.74 noticeable latency in response.