search

bldrs-ai / Share

Share is a web-based BIM & CAD collaboration platform.
http://bldrs.ai
103 stars 30 forks source link

System: Element selection performance sub par #619

Open Adrian62D opened 1 year ago

Adrian62D commented 1 year ago

Steps to reproduce:

  1. Select Seestrasse Model from the load dialog
  2. Change element selection by clicking on different walls

image

Expected: Selection changes in <50ms

Actual: Selection changes in approx 2 seconds

It seems that element selection performs way better on smaller models ("Momentum").

Ibrahim5aad commented 1 year ago

@Adrian62D I found out why this happens. It's not the selection itself it seems. Updating the TreeView expanded elements is blocking the app for some significant milliseconds, and it doesn't scale well with bigger models. This update is part of the selected elements effect. If you tried to comment out those calls to set the expanded tree items, you won't encounter such lag even in bigger models.

image

Adrian62D commented 1 year ago

@Ibrahim5aad Great, thank you! What options for action do we have? Could the handling of the three view be done without blocking the ui?