search

bldrs-ai / ifctool

Command line tools for working with IFC models
https://bldrs-ai.github.io/ifctool
16 stars 5 forks source link

IFCTool: Finalizing Flood Filling #26

Closed mkeshavarzi closed 2 years ago

mkeshavarzi commented 2 years ago

This is a draft PR for finalizing tests and resolving bugs for the 3D floodfilling alforithm. Tests would include unit tests and tests with simple three.js bounding boxes and imported obj bounding boxes.

pablo-mayrgundter commented 2 years ago

For draft PRs, it's actually a status set on the PR, not in the description. Toggle it here:

image

That will make it show up differently in the queue

pablo-mayrgundter commented 2 years ago

Heya, how's this going?

pablo-mayrgundter commented 2 years ago

Please merge from upstream then lmk

pablo-mayrgundter commented 2 years ago

Hey Mohammed, please address open comments from my review

mkeshavarzi commented 2 years ago

Hey Mohammed, please address open comments from my review

Hey Pablo - comments are addressed but "three" is still failing to import in tests.js.