Fix build with vala 0.46

bleakgrey / tootle

GTK-based Mastodon client for Linux

GNU General Public License v3.0

400 stars 61 forks source link

Fix build with vala 0.46 #164

Closed worldofpeace closed 5 years ago

worldofpeace commented 5 years ago

See: https://gitlab.gnome.org/GNOME/vala/issues/766

Fixes #163

worldofpeace commented 5 years ago

PR is on behalf of NixOS packaging, as in its latest released version it was failing to build

https://nix-cache.s3.amazonaws.com/log/jiavj60w6i4wypx87qaxa4j2aky3vp3w-tootle-0.2.0.drv

worldofpeace commented 5 years ago

Here's a version of the patch that applies to the released version

https://github.com/worldofpeace/tootle/commit/0a88bdad6d969ead1e4058b1a19675c9d6857b16 (perhaps useful to onlookers)

bleakgrey commented 5 years ago

This issue has been already resolved in the refactor branch. It will be merged when it's ready.

worldofpeace commented 5 years ago

Understood @bleakgrey, though having a stable release that doesn't build with latest vala isn't great for people that distribute this application. So I'd recommend having some sort of fix for a stable release.

Thanks for fixing it on the refactor branch :sparkles:.