bleakgrey / tootle

GTK-based Mastodon client for Linux
GNU General Public License v3.0
400 stars 61 forks source link

Fix build with vala 0.40 #168

Closed despair86 closed 4 years ago

despair86 commented 5 years ago

building refactor on Solaris 11 (yes weird) using Vala 0.40.15 spits out some errors. master works fine after removing build rules for libappstream-4 stuff that we simply don't use here.

$ valac --version
Vala 0.40.15
$ uname -a
SunOS sun-pc 5.11 illumos-fec6629365 i86pc i386 i86pc Solaris
../src/InstanceAccount.vala:122.5-122.40: error: `Tootle.InstanceAccount.on_notification': no suitable method found to override
    public override void on_notification (API.Notification obj) {
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
../src/InstanceAccount.vala:145.5-145.42: error: `Tootle.InstanceAccount.on_status_removed': no suitable method found to override
    public override void on_status_removed (int64 id) {
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
../src/InstanceAccount.vala:150.5-150.40: error: `Tootle.InstanceAccount.on_status_added': no suitable method found to override
    public override void on_status_added (API.Status status) {
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
../src/Services/Cache.vala:84.26-84.56: warning: unhandled error `GLib.Error'
                pixbuf = new Pixbuf.from_stream (stream);
                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
../src/Services/Cache.vala:85.17-85.31: warning: unhandled error `GLib.IOError'
                stream.close ();
                ^^^^^^^^^^^^^^^
../src/Widgets/Avatar.vala:62.13-63.104: warning: unhandled error `GLib.Error'
../src/Views/ExpandedStatus.vala:20.4-20.42: error: `Tootle.Views.ExpandedStatus.on_account_changed': no suitable method found to override
   public override void on_account_changed (InstanceAccount? acc) {
   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
../src/Views/Timeline.vala:33.5-33.40: error: `Tootle.Views.Timeline.on_status_added': no suitable method found to override
    public override void on_status_added (API.Status status) {
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
../src/Views/Timeline.vala:122.5-122.43: error: `Tootle.Views.Timeline.on_account_changed': no suitable method found to override
    public override void on_account_changed (InstanceAccount? acc) {
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
../src/Views/Timeline.vala:129.5-129.35: error: `Tootle.Views.Timeline.accepts': no suitable method found to override
    protected override bool accepts (ref string event) {
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
vitlav commented 4 years ago

Fix for release 0.2.0: https://aur.archlinux.org/cgit/aur.git/plain/fix-build-on-vala-46.patch?h=tootle