search

bleakgrey / tootle

GTK-based Mastodon client for Linux
GNU General Public License v3.0
401 stars 61 forks source link

Phones needs smaller width #179

Closed Alexmitter closed 4 years ago

Alexmitter commented 4 years ago

Hello

There is a issue with the minimal width of the MainWindow preventing the app from working right on mobile devices. Currently those devices all have 720p displays and range from a scaling factor of 1.5 to 2. So a minimum MainWindow width of 360px is needed.

tootle1

I did a crude fix to that fork called olifant so we have a working client but this also affects your rewrite.

ranfdev commented 4 years ago

The situation should improve after applying #176. But that's not enough, because the buttons under the post (favourite, boost, ...) are occupying too much space. Unfortunately I don't have the time to look into this at the moment

bleakgrey commented 4 years ago

I really wish I could make phoc compile. Adapting the UI would've been so much easier if I could actually see how it looks on them myself. :cry:

bleakgrey commented 4 years ago

Can you please check how master looks now?

Alexmitter commented 4 years ago

Hi, you can just use the qemu image provided by purism here: https://developer.puri.sm/Librem5/Development_Environment/Boards/qemu.html

I will test your changes in master today evening and give back my feedback.

Alexmitter commented 4 years ago

Hey, so I build it and it already is a big improvement. I just wonder why your bars are all so big, I would have probably just take a libhandy csd buttons example and adapted it. But generally it seems like everything is bigger then it should be.

new-tootle1

I hope the qemu image will work for you.

bleakgrey commented 4 years ago

I blame the avatars. Something's off in the way they calc their size, I think they multiply the scaling factor twice or something. I'll look into it.

bleakgrey commented 4 years ago

This is as small as the window can possibly get resized. I think it should be fine now. Screenshot from 2020-06-30 00-40-14

ranfdev commented 4 years ago

Mmmmm... IDs (account id, status id...) are different between instances. So... I think you can hide the account switcher btn when you show the back btn. When the back btn is visible, probably you are viewing a specific status or account, and you can't switch account while doing that anyway, because the IDs of the elements you are viewing are different after switching the account.

On Mon, Jun 29, 2020, 11:46 PM Bleak Grey notifications@github.com wrote:

This is as small as the window can possibly get resized. I think it should be fine now. [image: Screenshot from 2020-06-30 00-40-14] https://user-images.githubusercontent.com/20158357/86059230-01a3cb00-ba6b-11ea-970f-cade0773f620.png

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/bleakgrey/tootle/issues/179#issuecomment-651386305, or unsubscribe https://github.com/notifications/unsubscribe-auth/AFRXB2DQ6WNC2MSYETFAX23RZEDUHANCNFSM4ODCNXUA .

bleakgrey commented 4 years ago

@ranfdev I want to keep the ability to switch accounts at any time. IDs are indeed unique for each instance, but I don't think it matters because entities can be resolved by the instance by querying their URL.