bleakgrey / tootle

GTK-based Mastodon client for Linux
GNU General Public License v3.0
401 stars 61 forks source link

Design : Search button in headerbar #216

Closed lionirdeadman closed 4 years ago

lionirdeadman commented 4 years ago

Most GNOME apps use this location and it makes more sense than clicking it as an option in the account pop-over, I think.

bleakgrey commented 4 years ago

1.0 is supposed to perform well on smaller phone screens, so I don't have the luxury of packing more buttons into the header bar anymore.

Even though the current header bar design is frozen for now, I'm free to add plenty of keyboard shortcuts.

lionirdeadman commented 4 years ago

1.0 is supposed to perform well on smaller phone screens, so I don't have the luxury of packing more buttons into the header bar anymore.

Even though the current header bar design is frozen for now, I'm free to add plenty of keyboard shortcuts.

But you're already moving all the buttons in a bottom bar which leaves the headerbar mostly empty on smaller screens as mentioned in #195.

bleakgrey commented 4 years ago

If we're talking about global search (posts, accounts, hashtags), it makes no sense to display this button on every view as it's not even related to it. It's not filtering the timeline content, it's resolving instance entities.

Besides, even if it could work for Home screen (I'll admit, it's pretty empty), I can't move Profile's header bar content to the bottom bar. Even its title barely fits there.

lionirdeadman commented 4 years ago

Hm, yeah, in every view it wouldn't make sense. Maybe just Home. I still think it is strange to put it in the account pop-over.