search

bleakgrey / tootle

GTK-based Mastodon client for Linux
GNU General Public License v3.0
401 stars 61 forks source link

Crash on converting NotificationType to string while browsing certain instances #223

Closed Mek101 closed 4 years ago

Mek101 commented 4 years ago

Browsing certain instances (eg. baraag.net) crashes the application.

What should happen:

Tootle should not crash.

What happened instead:

The application crashes.

How to reproduce:

Seems to apply only to certain instances. pawoo.net works fine but trying to load anything from baraag causes crashes. Pawoo being based over mastodon 2.4.0 and the latter on 3.2.0 could be a factor.

Build context:

Logs:

mek101@mint19-desktop:~$ flatpak run com.github.bleakgrey.tootle 
[INFO 10:55:55.817219] Application.vala:155: Tootle version: 0.2.0
[INFO 10:55:55.817248] Application.vala:157: Kernel version: 5.4.0-42-generic
[INFO 10:55:55.860746] Notificator.vala:40: Starting: /api/v1/streaming/?stream=user
[INFO 10:55:55.860862] Notificator.vala:40: Starting: /api/v1/streaming/?stream=user
[INFO 10:55:55.874525] Notificator.vala:40: Starting: /api/v1/streaming/?stream=user
[INFO 10:55:55.876843] Notificator.vala:40: Starting: /api/v1/streaming/?stream=public:local
[INFO 10:55:55.877802] Notificator.vala:40: Starting: /api/v1/streaming/?stream=public

(com.github.bleakgrey.tootle:2): Gtk-WARNING **: 10:55:55.930: gtk_window_set_titlebar() called on a realized window
[INFO 10:55:57.429377] Watchlist.vala:23: Reloading
[INFO 10:55:57.429434] Watchlist.vala:34: Watching for 0 users and 0 hashtags
**
ERROR:com.github.bleakgrey.tootle@exe/src/API/NotificationType.c:215:tootle_notification_type_from_string: code should not be reached

Additional info (if needed):

Pawoo being based over mastodon 2.4.0 while baarag on 3.2.0 could be a factor.

bleakgrey commented 4 years ago

Fixed in master.