search

bleakgrey / tootle

GTK-based Mastodon client for Linux
GNU General Public License v3.0
401 stars 61 forks source link

new-account: Slight redesign #273

Closed Kekun closed 3 years ago

Kekun commented 3 years ago

This makes the code simpler, implements the latest GNOME HIG standard, gives a back gesture, and makes the dialog it fit phones.

bleakgrey commented 3 years ago

I can't seem to make libhandy compile as a meson submodule. The compilation fails with error: Package fribidi not found in specified Vala API directories or GObject-Introspection GIR directories.

Kekun commented 3 years ago

We depend on it since yesterday to correctly handle text direction in our new HdyTabBar widget.

I'd suggest, if possible, to not include libhandy as a submodule and to use it from the master GNOME SDK. Alternatively: include fribidi as a submodule or use an older commit in your submodule.

Kekun commented 3 years ago

Or maybe just install fribidi in your CI, it's a very stable lib, as in Debian Stable: it didn't evolve since years, so it won't be an issue.

Kekun commented 3 years ago

Anyway, that's completely unrelated to that MR.