search

bleehu / CXDocs

Compound X rules displayed as web pages. Written in Python, served with Flask and bootstraped with bootswatch.
1 stars 1 forks source link

Ak/front end/#207/navigation #243

Closed RyuGuardian closed 5 years ago

RyuGuardian commented 5 years ago

This combines some styling changes with code changes. It will probably be easier to check changes on each commit. The first three and the fifth one are really small. The fourth one is the large styling change, and the last one is the code change.

bleehu commented 5 years ago

I'm getting an error on line 61 in nav.py. the item navbar tuples are being interpreted as strings, so instead of iterating across the route, it's iterating across the string. So it's throwing an error looking for the route 'r'. A little concerned about overloading the route the way that we are, but if it works, go for it.

RyuGuardian commented 5 years ago

@bleehu Thanks for reviewing, but I'm not gonna merge this yet (my bad; I waited too long). I'm still working on the branch, and it's going to conflict with your PRs. I'll try to review yours tonight or tomorrow so I can merge with master soon with your changes and update this branch. Sound good?

bleehu commented 5 years ago

Sounds good! Let me know if I can help!