search

bleehu / CXDocs

Compound X rules displayed as web pages. Written in Python, served with Flask and bootstraped with bootswatch.
1 stars 1 forks source link

Mh/issue 230/clean configs #245

Closed bleehu closed 5 years ago

bleehu commented 5 years ago

Should address Issue #230 and make other improvements to the way we handle configs.

bleehu commented 5 years ago

This should also close issue #196

bleehu commented 5 years ago

Remind me when I merge this that I'll need to update the remote server to have a capitol 'A' in the auth section of the configs.

RyuGuardian commented 5 years ago

Oh, one more thing to mention: there's a little inconsistency in some of our naming of folders/files. I was doing research when figuring out how to name my own files and folders and found people referring to PEP 8 for Python stuff. I noticed you named modules (technically packages, which should be all lowercase with no underscores) with camel case. Modules are technically individual files (a package contains modules), which should be all lowercase with underscores if necessary. Want to weigh in on this?

Reference: https://www.python.org/dev/peps/pep-0008/#package-and-module-names

bleehu commented 5 years ago

In reply to module names, package names, and I'd like to add my variable names, and function names; I do a really crappy job of following convention and I really need to fix that. Especially since we're using Python, the PEP8 is a good standard to follow. I'll clean those up as part of addressing https://github.com/bleehu/CXDocs/issues/247

Turtlelord26 commented 5 years ago

"Remind me when I merge this that I'll need to update the remote server to have a capitol 'A' in the auth section of the configs." @bleehu