Edited navigation module to hopefully make it more manageable

bleehu / CXDocs

Compound X rules displayed as web pages. Written in Python, served with Flask and bootstraped with bootswatch.

1 stars 1 forks source link

Edited navigation module to hopefully make it more manageable #248

Closed RyuGuardian closed 5 years ago

RyuGuardian commented 5 years ago

Changed names to be more accurate/meaningful (such as file names, functions, and parameters)
Separated dict files more to work within categories (this will likely change in the future, as it should ideally, if we can manage it, closely reflect how the site is navigated)
Created navbar tuples for more DRY code and help determine what navigation should look and act like (looking to make this even more DRY in the future)
Added a couple paths to theoretical pages (right now they use the home.html template; they can be easily changed to use new templates or docs)
Added a function to help aggregate the nav dict so paths can be obtained via explicit dicts and the config filepath options

RyuGuardian commented 5 years ago

Sorry for another large change to navigation. I already have another branch ready to go after this that adds side-bar navigation, though!

bleehu commented 5 years ago

Don't forget to request reviews in the menu to the right and assign the issue to the reviewer :)

RyuGuardian commented 5 years ago

Yeah, I always forget that... :-(

bleehu commented 5 years ago

CSS error in 207

bleehu commented 5 years ago

CSS error 2

Is this in-progress?

bleehu commented 5 years ago

Combat rules and basic rules look better, and the bestiary looks waaay better. I've run this twice, and gotten different layouts occur? The nav bar seems to be behaving weirdly.

RyuGuardian commented 5 years ago

@bleehu Do a Ctrl+F5 refresh to ensure a reload of the stylesheet. Hopefully that fixes the navbar issue if it's changing sizes or something. The selection of buttons on the navbar can change depending on which page you're on.

bleehu commented 5 years ago

what is going on

I used ctrl+f5 to hard refresh, rather than refreshing from cache. The /weapons route in particular doesn't show any weapons? What is the problem you're trying to solve?

RyuGuardian commented 5 years ago

I was thinking the weapons homepage (/weapons/) would show/explain how weapons work, focusing on them as items to be used and explaining their stats. Then from there you can navigate to types of weapons (I have that implemented in the sidebar branch I'll push later). There would also be an explanation on how weapons work in rules (/rules/weapons or /rules/combat, or both), which focuses on calculating for checks.

The weapons pages used right now are more like shop fronts since they list individual items with stats and prices. (These definitely need to be something implemented into a database.)

bleehu commented 5 years ago

Oh! Ok, that all makes sense. I think I understand your thinking a lot better now. Thanks!

RyuGuardian commented 5 years ago

@bleehu Merged with master. Approval, please?

bleehu commented 5 years ago

Try merging master now; I think I fixed the tests.

RyuGuardian commented 5 years ago

@bleehu Done!