search

bleenco / ngx-uploader

Angular File Uploader
https://ngx-uploader.jankuri.me
MIT License
756 stars 348 forks source link

Extend peer dependencies to Angular 8 #492

Open agil-NUBBA opened 5 years ago

agil-NUBBA commented 5 years ago

Issue description

running npm install throws the following warning:

npm WARN ngx-uploader@7.1.0 requires a peer of @angular/common@^7.1.4 but none is installed. You must install peer dependencies yourself.
npm WARN ngx-uploader@7.1.0 requires a peer of @angular/core@^7.1.4 but none is installed. You must install peer dependencies yourself.

Steps to reproduce and a minimal demo of the problem

npm install with Angular 8

Current behavior

npm install shows a couple of warning due to peer dependencies.

Expected/desired behavior

No warnings should be shown

vecernik commented 5 years ago

+1

ofirrifo commented 5 years ago

+1

neergli commented 5 years ago

+1

Plondrein commented 5 years ago

any update on this? Angular 9 is coming

tibinvpaul commented 4 years ago

Very much needed. I appreciate the help here!