blei-lab / edward

A probabilistic programming language in TensorFlow. Deep generative models, variational inference.

http://edwardlib.org

Other

4.83k stars 759 forks source link

Implementation of replica exchange MCMC #865

Closed YoshikawaMasashi closed 6 years ago

YoshikawaMasashi commented 6 years ago

861

Happy to open this pull request. I implemented replica exchange MCMC. I would appreciate it if you would review and comment.

YoshikawaMasashi commented 6 years ago

I apologize. I'll fix it.

YoshikawaMasashi commented 6 years ago

Thank you for your quick and polite comments!

Based on your comment, I corrected everything I can fix.

But, the Travis CI check does not pass. From d567b67eea0c24d389d0755e728ea4982fe378cd that pass through all checks, I didn't change except variable names and indent. The error is occurring in the code to run HMC of the eight_schools.ipynb, and KeyboardInterrupt is occurring. Therefore, I suspect that this error has nothing to do with the changes I made. Can I perform retest?

dustinvtran commented 6 years ago

Sure, restarting job.

YoshikawaMasashi commented 6 years ago

Thank you very much! And I'm happy that all checks passed. I would appreciate it if you would check.

dustinvtran commented 6 years ago

All looks great. Thanks again!