bleistivt / yaga

YAGA adds reactions, badges and ranks to your Vanilla forum.
GNU General Public License v2.0
13 stars 2 forks source link

Using own reaction icons is not intuitive #26

Closed R-J closed 3 years ago

R-J commented 4 years ago

As far as I can tell the list of reactions is hard coded into ActionController->edit(). If you know some CSS you can see that with defining your custom css class you would be able to use your own icon as a reaction. But you need to know that, there is no hint at all.

I would suggest to open the reaction edit/add view not a a popup but as a full view so that you can make use of the helpAsset() helper function in order to give a short example.

That might be too bloated and maybe putting that as an additional pargraph below the edit/add form control would be better. Eventually that could come with an example

bleistivt commented 4 years ago

It is actually planned to make the reaction edit screen similar to the badge screen where you can upload your own icon. I was kind of hoping for dashboard SVG uploads https://github.com/vanilla/vanilla/issues/6089, but that issue got eaten by the stale bot.

Still, simply swapping Gdn_UploadImage for Gdn_Upload might work.

bleistivt commented 4 years ago

@R-J Just saw your topic here: https://open.vanillaforums.com/discussion/38275/yaga-how-to-use-custom-icons-for-reactions

UTF-8 emojis are an intriguing alternative too... I'm thinking about something that would enable users to do both from the UI.

Maybe an image upload and a text alternative (if no image is supplied) which would otherwise become the alt attribute?

bleistivt commented 3 years ago

https://github.com/bleistivt/yaga/commit/ce23d11a72b293f0619cc732a98e7eb41118d5fe implements the proposed system