search

blekerfeld / donut

Donut, dictionary toolkit
MIT License
9 stars 3 forks source link

mPDF: fork or just leave as permanent dependency, any thoughts? #33

Closed blekerfeld closed 7 years ago

blekerfeld commented 7 years ago

For Dictionary PDF generation, Donut uses the mPDF library, but because of its poor php 7.1 support, the development branch had to be used, I fixed lots of things myself and even implanted new functions that work together with donut.

The thing is, installing via composer, will just pull a version from the mPDF-repository that does not work 100% with Donut. Which is why for now, my custom mPDF-library is permanently included as vendor.

I might fork it at sometime and requite my own fork via composer, for now this works.

Any thoughts?

P.S. Version requirement should probably be bumped to php 7+ because of mPDF, but it might just work (untested), otherwise another posibility is just to turn of pdf generation if an older php version is detected...

blekerfeld commented 7 years ago

Created a fork, as otherwise the repository would be gigantic. Donut now uses blekerfeld/mpdf for pdf-generation. Updates and fixes to mPdf will be pushed to that fork. Furthermore are all php dependencies installed by composer now, about time!