Closed Beerlesklopfer closed 4 years ago
I don't have the time nor the circuitry to test that code at the moment. That's a shame cause I really think it's a nice addition to the library :)
Let me know If you ever have the chance to the test that code, especially the fact that any change to the register can be reverted without a chip reboot to keep things consistent with the rest the library. Why not merge that PR after all ? :)
Salut Bertrand,
J'ai créé une nouvelle demande d'extraction et j'ai fusionné le code vérifié. De plus, j'ai légèrement révisé la documentation pour que le wiki puisse la reprendre.
Peut-être que je enverrai le wiki plus tard á tois.
Une semaine bonne et saine pour tois.
Cordialement Jörg
Gesendet: Samstag, 29. Februar 2020 um 13:29 Uhr Von: "Bertrand Lemasle" notifications@github.com An: blemasle/arduino-mcp23017 arduino-mcp23017@noreply.github.com Cc: "Jörg Bernau" Joerg.Bernau@web.de, "State change" state_change@noreply.github.com Betreff: Re: [blemasle/arduino-mcp23017] Adding inverted input capability (#14)
I don't have the time nor the circuitry to test that code at the moment. That's a shame cause I really think it's a nice addition to the library :)
Let me know If you ever have the chance to the test that code, especially the fact that any change to the register can be reverted without a chip reboot to keep things consistent with the rest the library. Why not merge that PR after all ? :)
— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub, or unsubscribe.
MCP23017 16-Bit I/O Expander with Serial Interface
|
Bonjour Jörg :)
Thanks again for the input. I'm sorry for the reaction time, but I've just started a new job a few days ago and It has been going like crazy since then :) For instance, this is the first opportunity I had to check my mails since last sunday :/
Anyway, I'll review your changes as soon as I can and probably accept the PR once done. One question though, what did you use to generate the wiki content from the comments ?
Regards, Bertrand
On Sun, Mar 1, 2020 at 7:52 PM Jörg Bernau notifications@github.com wrote:
Salut Bertrand,
J'ai créé une nouvelle demande d'extraction et j'ai fusionné le code vérifié. De plus, j'ai légèrement révisé la documentation pour que le wiki puisse la reprendre.
Peut-être que je enverrai le wiki plus tard á tois.
Une semaine bonne et saine pour tois.
Cordialement Jörg
Gesendet: Samstag, 29. Februar 2020 um 13:29 Uhr Von: "Bertrand Lemasle" notifications@github.com An: blemasle/arduino-mcp23017 arduino-mcp23017@noreply.github.com Cc: "Jörg Bernau" Joerg.Bernau@web.de, "State change" < state_change@noreply.github.com> Betreff: Re: [blemasle/arduino-mcp23017] Adding inverted input capability (#14)
I don't have the time nor the circuitry to test that code at the moment. That's a shame cause I really think it's a nice addition to the library :)
Let me know If you ever have the chance to the test that code, especially the fact that any change to the register can be reverted without a chip reboot to keep things consistent with the rest the library. Why not merge that PR after all ? :)
— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub, or unsubscribe.
— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/blemasle/arduino-mcp23017/pull/14?email_source=notifications&email_token=ABHRZYPM3JUFTY3IFPG6VZ3RFKVGTA5CNFSM4K2XNLAKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOENNHMXY#issuecomment-593131103, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABHRZYLWIBPA5CSKEMBNHALRFKVGTANCNFSM4K2XNLAA .
Hi Bertrand,
I used Doxygen first and pandoc afterwards. The rest was manual editing.
Regards Jörg
I neded an inverted input for my application so I am share my changes with you.