blendle / kns

quick Kubernetes Namespace Switcher
ISC License
295 stars 27 forks source link

measly attempt at a ktx tool #4

Closed cmeury closed 6 years ago

cmeury commented 6 years ago

Not sure what to really display in the preview window. What do you think?

screen shot 2018-03-24 at 23 13 21

(Note to future self: In the off-chance this PR is successful, need to make a PR for the tap as well. Also see help for distributing shell scripts via homebrew.)

cmeury commented 6 years ago

Thanks @koenbollen. I pushed fixes for the shellcheck reports.

cmeury commented 6 years ago

So you think ktx is a thing? If yes, let me know, and I'll extend the README etc. as well.

koenbollen commented 6 years ago

Yeah, lets do this. I do however want to keep the focus on the kns tool where the ktx is an extra (my guess it that namespace switching is more common then context switching).

cmeury commented 6 years ago

Yes, I totally agree. kns is the star here. By the way, I was incredibly surprised to see how short the script is after using it for quite a while (a lot). Excellent job!

cmeury commented 6 years ago

@koenbollen Added a small README section.

koenbollen commented 6 years ago

Nice. But shouldn't we just install ktx in the homebrew formula?

cmeury commented 6 years ago

Sure! Honestly, whatever you think is best. No strong opinions on my side. Should I remove the section then? Or what would be your suggestion?

koenbollen commented 6 years ago

Keep the section. Just explain that ktx is a part of this package and what it does. 👍

cmeury commented 6 years ago

@koenbollen Done

koenbollen commented 6 years ago

@cmeury I guess it's done. I'll try and get a colleague to check it out and then I'll merge it.

koenbollen commented 6 years ago

@koenrh

Could you update the Homebrew formula to install both kns and ktx?

I will! 👍

koenbollen commented 6 years ago

@cmeury I've updated our Homebrew tab: https://github.com/blendle/homebrew-blendle/pull/22

Thanks for your contribution! 🎉

cmeury commented 6 years ago

Awesome :) Happy switching!