Code for categorical features is broken/incomplete

blent-ai / ALEPython

Python Accumulated Local Effects package

Apache License 2.0

158 stars 42 forks source link

Code for categorical features is broken/incomplete #6

Open joby-h20 opened 4 years ago

joby-h20 commented 4 years ago

I believe that code for _first_order_ale_cat is broken or incomplete.

MaximeJumelle commented 4 years ago

Hello,

Indeed the function _first_order_ale_cat is not providing the expected output. It is due to the fact that sorting categorical feature is a bit more complicated than with numerical features. It is suggested to use a dimensionality reduction algorithm such as MDS to provide a one-dimensional array with numerical features to easily sort it.