search

blepping / comfyui_jankhidiffusion

Janky implementation of HiDiffusion for ComfyUI
Apache License 2.0
110 stars 7 forks source link

Your ApplyRAUNet freezes gen on DirectML (probably on MPS too) *Solved below* #1

Closed MythicalChu closed 6 months ago

MythicalChu commented 6 months ago

It's the same problem that happened on IpAdapter and , I think, on base ComfyUI too:

https://github.com/cubiq/ComfyUI_IPAdapter_plus/issues/109#issuecomment-2004516030

I didn't even need to debug your code, just went ahead and altered, on raunet.py, the following lines:

line 26: sigma = sigma.max().item() to: sigma = sigma.max().detach().cpu().numpy()

lines 263 and 277: sigma = extra_options["sigmas"].max().item() to: sigma = extra_options["sigmas"].max().detach().cpu().numpy()

and problem fixed.

blepping commented 6 months ago

thanks for the bug report! does the latest commit ( https://github.com/blepping/comfyui_jankhidiffusion/commit/e693373a128156b874677dc3868d7d63e2c7584c ) fix your issue? i took a slightly different approach.

MythicalChu commented 6 months ago

It seems to have worked, thanks! (haven't tested extensively yet, but it happened right at 1st gen and now it doesn't anymore, so...)

blepping commented 6 months ago

not a problem. let me know if you run into any other issues!