blepping / comfyui_jankhidiffusion

Janky implementation of HiDiffusion for ComfyUI
Apache License 2.0
110 stars 7 forks source link

Confetti problem in SDXL #4

Closed tudal closed 4 months ago

tudal commented 4 months ago

Ok so first of all this is real game changer, works insanely well!

Only problem I have is when I run it in SDXL with settings from example workflow. There's a lot of "confetti" on pictures (noise). Especially with dpmpp_2m at low steps. 3m and high steps is okayish, but its still visible. So I started tweaking the numbers randomly and those settings seems to do the job (0 confetti):

image

Not really issue ;) can be closed

blepping commented 4 months ago

you've actually just set the ApplyRAUNet node to not do anything. :) ca_start_time is 1.0 so it'll never activate. input block 6 for SDXL isn't a downsampler block and output block 3 isn't an upsampler block so that part also never has an effect.

if you're getting good results with those settings you basically just don't need the RAUNet stuff at all. what resolution are you trying to generate at?

kubilaykilinc commented 4 months ago

image

https://github.com/blepping/comfyui_jankhidiffusion/blob/main/assets/sdxl_workflow.png

I applied the above settings to your example SDXL workflow. It was okay. Thanks. This works.

kubilaykilinc commented 4 months ago

image It works fine without any problems. The balloons disappeared. This problem only occurs on faces. This also happens on the other Hidiffusion custom node. I think it's related to the chosen resolution. Someone on Reddit wrote that there is no problem when applying the Standard SDXL dimensions by multiplying them by 1.5. I will try.

kubilaykilinc commented 4 months ago

This is 1.5 multiplier 1024x1024 pixel - (1536 x 1536). Working fine anatomy. I will examine different resoulitions. image

blepping commented 4 months ago

@kubilaykilinc

I applied the above settings to your example SDXL workflow. It was okay. Thanks. This works.

i'm confused as to why it works. you're downscaling but never upscaling because output 3 isn't an upsample block - so that part will have no effect at all. for SDXL, only targetting input 3 or 6, only targetting output 5 or 2 will have an effect. the patch can only apply to the correct block type, so if you try to use an input block that isn't actually a downscale block or an output block that isn't actually an upscale block then the handler will just never activate.

maybe the tensors broadcast or something, i'm not sure.

blepping commented 4 months ago

i'm going to close this now. any of the participants: please feel free to open another issue if you still have unresolved problems/questions.

patientx commented 2 months ago

This is 1.5 multiplier 1024x1024 pixel - (1536 x 1536). Working fine anatomy. I will examine different resoulitions. image

no matter what I try I can't get decent generation besides the sample workflow, can you share some workflow you use for sdxl with hidiffusion ? (selam!)