search

bleroy / Nwazet.Commerce

Idiomatic commerce module for Orchard CMS.
BSD 3-Clause "New" or "Revised" License
26 stars 21 forks source link

ProductPart versioning #112

Closed MatteoPiovanelli-Laser closed 7 years ago

MatteoPiovanelli-Laser commented 7 years ago

@bleroy in #101

inventory is not versionable iirc, and probably shouldn't be. I'm not sure that's a problem. Price on the other hand, should probably be versionable. Maybe we should have an issue to track this and consider what should and shouldn't be versionable.

MatteoPiovanelli-Laser commented 7 years ago

My ideas on whether the different properties of a ProductPart should version:

Property Versioning
Sku I think this should be a constant, across all versions of the product. So I would synchronize this between Latest and Published (there should be in general no need to synchronize on other versions, I think)
Price Version normally
DiscountPrice Version normally
IsDigital Version normally. I see this changing mostly to fix data entry mistakes.
ConsiderInventory Version normally. I see this changing mostly to fix data entry mistakes.
ShippingCost Version normally
Weight Version normally
Size Version normally
Inventory I think this should be constant across versions.
OutOfStockMessage Version normally
AllowBackOrder Version normally
OverrideTieredPricing Version normally
PriceTiers Version normally
MinimumOrderQuantity Version normally
AuthenticationRequired Version normally

To keep in synch different versions I would do something like we did for the CultureNeutral settings for localization, only specific to the properties that we wish to synchronize rather than generic to everything..

MatteoPiovanelli-Laser commented 7 years ago

I'll close this because it was merged in #96