Territories Feature - Githubissues

bleroy / Nwazet.Commerce

Idiomatic commerce module for Orchard CMS.

BSD 3-Clause "New" or "Revised" License

26 stars 21 forks source link

Territories Feature #140

Closed MatteoPiovanelli-Laser closed 6 years ago

MatteoPiovanelli-Laser commented 6 years ago

As discussed in #134, here's the PR for the new feature.

The csproj files, as usual, have been edited to try and go around the fact that the solution I work on is not the same solution as the on with Orchard's modules. This is messier the more changes I make. It's worse for the test project, I think.

Please, verify that the csproj files are such that all references and ProjectReferences are correct, for both the module and the tests. I based the latter on the csproj for Orchard.Tests.Modules.

I have also deleted the .orig files mentioned in #137

MatteoPiovanelli-Laser commented 6 years ago

In addition to the changes for the review, I changed the js for the UI of the teritories in the hierarchy so there is no limit to the number of nested levels.

bleroy commented 6 years ago

Thanks for the changes. Are we OK to merge, or are there any more changes pending?

MatteoPiovanelli-Laser commented 6 years ago

I am fine with merging this. Afterwards I'll open separate issues for:

bulk operations on Territories (select many - delete and stuff like that)
Localization extension: when you are localizing a hierarchy, it "prepares" things by cloning over the territories ready to be localized and other stuff like that.
Improved UI: as it is, the UI for the territories in a hierarchy is rather cumbersome.

MatteoPiovanelli-Laser commented 6 years ago

thanks for the merge