search

bleroy / Nwazet.Commerce

Idiomatic commerce module for Orchard CMS.
BSD 3-Clause "New" or "Revised" License
26 stars 21 forks source link

Not issue but request for Orders: put them in dedicated feature #19

Closed bleroy closed 8 years ago

bleroy commented 10 years ago

Originally reported by: Christian Surieux (Bitbucket: csurieux, GitHub: csurieux)

Hi Bertrand, Could you place your new order in a dedicated feature for the module? This could allow an easier upgrade for datwendo.commerce which has also orders, I would do the same in my code.

Thanks CS

bleroy commented 10 years ago

Original comment by Bertrand Le Roy (Bitbucket: bleroy, GitHub: bleroy):

Fixed in 67e1c8d617f5734bef1eec96eab7924ce7676b3a

bleroy commented 10 years ago

Original comment by Bertrand Le Roy (Bitbucket: bleroy, GitHub: bleroy):

WARNING: if you took the previous changesets, you may have to go into the Orchard_Framework_DataMigrationRecord database table and set the Nwazet.Commerce.Migrations.CommerceMigrations record to 6, and add a Nwazet.Commerce.Migrations.OrderMigrations with version 1.

bleroy commented 10 years ago

Original comment by Christian Surieux (Bitbucket: csurieux, GitHub: csurieux):

Thanks, on my side my order controller is only dealing with order related tasks, not implyed in the checkout, I use a dedicated controller to deal with checkout tasks.....the only one is generating an unique number for new orders. For this I am using a construct I am not satisfied with and certainly not recommended by w3c :), but gives full satisfaction at that day: before submitting to the payment platform submit, in the same click event I post an ajax call to get order number, and when ok, I push to payment the html they request. Doing this I prevent numerous non terminated orders where the user stop before submiting...but I can't avoid orders non terminated due to abandons on payment platform.

bleroy commented 10 years ago

Original comment by Bertrand Le Roy (Bitbucket: bleroy, GitHub: bleroy):

I've been thinking about this a little more. I need checkout to be able to depend on the availability of the order controller, with a create action with the right signature in order to be able to point to it and finalize the transaction. I'm still not sure how I can accomplish that, but there may be a way by having the controller be in the core module, but having it defer all logic to a replaceable interface. Would that work for you?

bleroy commented 10 years ago

Original comment by Bertrand Le Roy (Bitbucket: bleroy, GitHub: bleroy):

No, I can't, sorry. I need it to be in the main feature of the module, like product.