search

bleroy / Nwazet.Commerce

Idiomatic commerce module for Orchard CMS.
BSD 3-Clause "New" or "Revised" License
26 stars 21 forks source link

Attribute editor throws when price adjustment is left empty #35

Closed bleroy closed 8 years ago

bleroy commented 10 years ago

Originally reported by: Bertrand Le Roy (Bitbucket: bleroy, GitHub: bleroy)

All changes are lost, which is bad, mmmkay?

bleroy commented 9 years ago

Original comment by Josh Berry (Bitbucket: joshberry, GitHub: joshberry):

I think this one can be marked as resolved.

bleroy commented 10 years ago

Original comment by Josh Berry (Bitbucket: joshberry, GitHub: joshberry):

Submitted pull request #18 to fix this issue.

bleroy commented 10 years ago

Original comment by Bertrand Le Roy (Bitbucket: bleroy, GitHub: bleroy):

I'm sorry, I wrote that comment thinking I was on another issue. I don't have an example for this.

bleroy commented 10 years ago

Original comment by Josh Berry (Bitbucket: joshberry, GitHub: joshberry):

Can you point me to one of the examples you mentioned? I think I'm making this more complicated than necessary.

bleroy commented 10 years ago

Original comment by Josh Berry (Bitbucket: joshberry, GitHub: joshberry):

No. I should have. At one point I had a mostly working solution but got pulled into something else and never got back to it. I'll see what I can do.

bleroy commented 10 years ago

Original comment by Bertrand Le Roy (Bitbucket: bleroy, GitHub: bleroy):

Was this fixed?

bleroy commented 10 years ago

Original comment by Josh Berry (Bitbucket: joshberry, GitHub: joshberry):

Just saw this. I'll take a look.