search

bleroy / Nwazet.Commerce

Idiomatic commerce module for Orchard CMS.
BSD 3-Clause "New" or "Revised" License
26 stars 21 forks source link

Included and Excluded Shipping Areas #43

Closed bleroy closed 8 years ago

bleroy commented 10 years ago

Originally reported by: Anonymous

There is Included and Excluded Shipping Areas in some parts which implement IShippingMethod they don't work correctly. Also i cannot see any usage of these properties in ComputePrice method to prevent returning ShippingOption when order destination does not match with these areas.

bleroy commented 10 years ago

Original comment by Bertrand Le Roy (Bitbucket: bleroy, GitHub: bleroy):

Fixed

bleroy commented 10 years ago

Original comment by Bertrand Le Roy (Bitbucket: bleroy, GitHub: bleroy):

You're right. I pushed a fix for the checkbox ids. The included and excluded areas bug is of historic origins: when this feature was first added, the only available checkout method was Google Checkout, where the selection of a shipping method was handled by Google. We just had to send them the info. Since this checkout method is no longer available, the capability has not been retrofit into Nwazet Commerce.

bleroy commented 10 years ago

Original comment by Mehran Rezaei (Bitbucket: mehranrezaei, GitHub: mehranrezaei):

I looked for any usage of these to filter available ShippingOptions, But i couldn't find anything. I test this feature as the following process:

  1. I added new weight-base shipping method in admin UI.
  2. I checked "World" as included shipping area and "Canada" and "All US states" as excluded shipping area.
  3. I selected "United States" or "Canada" as country in shipping form and entered zip code in these country.
  4. I can see above shipping method available to select yet.
  5. I think this is incorrect.
  6. I think Included and Excluded Shipping Areas are not applied.

Also please be aware that label id for excluded shipping areas are same as included shipping areas and this causes UI bug.

Please tell me if i am wrong.

bleroy commented 10 years ago

Original comment by Bertrand Le Roy (Bitbucket: bleroy, GitHub: bleroy):

You will have to be more specific. How do they not work?