Stripe Feature has Unlisted Dependency on Nwazet.Orders Feature

bleroy / Nwazet.Commerce

Idiomatic commerce module for Orchard CMS.

BSD 3-Clause "New" or "Revised" License

26 stars 21 forks source link

Stripe Feature has Unlisted Dependency on Nwazet.Orders Feature #48

Closed bleroy closed 8 years ago

bleroy commented 10 years ago

Originally reported by: Anonymous

Nwazet.Commerce.Controllers.StripeController is listed as a "Stripe" feature and it utilizes "IOrderService" which is currently only resolvable when the "Nwazet.Orders" feature is enabled. I don't believe there is a way of removing this dependency though it would be nice. I have an example where I just want a user to "SendMoney" without the overhead of Nwazet.Orders. Look forward to your thoughts.

Bitbucket: https://bitbucket.org/bleroy/nwazet.commerce/issue/48

bleroy commented 10 years ago

Original comment by Bertrand Le Roy (Bitbucket: bleroy, GitHub: bleroy):

I added the dependency to the manifest.

bleroy commented 10 years ago

Original comment by Bertrand Le Roy (Bitbucket: bleroy, GitHub: bleroy):

There is no overhead associated with orders, the Stripe feature is not designed to do anything else than generate orders. There must be a trace even if a user "just" wants to send money: that's an order. We do already have that feature built-in, by the way.

bleroy commented 10 years ago

Original comment by Jeffrey Olmstead (Bitbucket: ems, GitHub: ems):

This was my "Issue" - wasn't logged in when I posted, ugh.