search

bleroy / Nwazet.Commerce

Idiomatic commerce module for Orchard CMS.
BSD 3-Clause "New" or "Revised" License
26 stars 21 forks source link

About Reports #57

Open bleroy opened 9 years ago

bleroy commented 9 years ago

Originally reported by: Mehran Rezaei (Bitbucket: mehranrezaei, GitHub: mehranrezaei)

  1. It seems that Reports does not support other cultures than en-US. For example in any culture you see en-US month names in charts. Or about currency. In any culture i see currency is $.
  2. I think chartjs is not best choice for this module. it uses canvas (instead of svg) and does not support right to left. Even in left to right it has some bugs.
  3. In next release of Orchard (1.x) there are some changes about Date and time localization. For example IDateService has been removed and in Report Controller we must use IDateLocalizationServices. Also about date picker there are some changes.
bleroy commented 9 years ago

Original comment by Bertrand Le Roy (Bitbucket: bleroy, GitHub: bleroy):

Feel free to submit a pull request, I'll take it.

bleroy commented 9 years ago

Original comment by Mehran Rezaei (Bitbucket: mehranrezaei, GitHub: mehranrezaei):

I think svg is better than canvas for css styling and responsive layout. But this is not main reason that i said chartjs is not best option. chartjs has some bugs specially in RTL and non English languages. It has not much capability.

http://www.sitepoint.com/7-reasons-to-consider-svgs-instead-of-canvas/

http://msdn.microsoft.com/en-us/hh552482.aspx

http://blog.lingohub.com/developers/2014/06/comparison-angularjs-directives-charts-front-end-app-development/

bleroy commented 9 years ago

Original comment by Bertrand Le Roy (Bitbucket: bleroy, GitHub: bleroy):

What's wrong with canvas?