search

bleroy / Nwazet.Commerce

Idiomatic commerce module for Orchard CMS.
BSD 3-Clause "New" or "Revised" License
26 stars 21 forks source link

jquery-datetime-editor.js removal from Orchard.JQuery causes nwazet.commerce reports to crash #77

Closed bleroy closed 7 years ago

bleroy commented 9 years ago

Originally reported by: Dieter Schüle (Bitbucket: dpomt, GitHub: dpomt)

nwazet.commerce reports relay on jquery-dateime-editor.js which was removed from orchard.jquery sometime ago:

Author: Sipke Schoorstra sipke@orchardpros.net#mailto:sipke@orchardpros.net Date: 11 months ago (25.07.2014 06:18:08) Commit hash: 4ba6bcdbc0d9ef7fa65e30d6d0cc52b9d5712bb9 Parent(s): be37ee54dc

Posted this also in Orchard forum (https://github.com/OrchardCMS/Orchard/issues/5385) since I do not know whether it should be fixed there or here.

bleroy commented 9 years ago

Original comment by Bertrand Le Roy (Bitbucket: bleroy, GitHub: bleroy):

You're welcome.

bleroy commented 9 years ago

Original comment by Dieter Schüle (Bitbucket: dpomt, GitHub: dpomt):

Thanks for your ultra quick response. You are right, I did not pull your latest changes. Works fine again. Thanks!!

bleroy commented 9 years ago

Original comment by Bertrand Le Roy (Bitbucket: bleroy, GitHub: bleroy):

I'm pretty sure I already fixed that. Did you get the latest code?

MatteoPiovanelli-Laser commented 7 years ago

I actually found this same issue pulling the master from github. I fixed it on a branch, along with a few other changes ito bring everything up to date with the latest Orchard 1.10. However, I am not making a PR right now, because I noticed that I have local HintPaths in the csproj files. I'll fix that and do a PR later.

MatteoPiovanelli-Laser commented 7 years ago

I see what the issue is on my end:

I have an usual folder structure because I keep the non-core modules (meaning, all modules that are not form the Orchard official repo) in a different folder, that is also a different solution and a different git-repo.

Basically, since my local Nwazet.Commerce module is not in the main OrchardCMS solution, but in a different one, in the csproj I have a different path for the NuGet packages, and those that would be ProjectReferences to Orchard Modules become References to external dlls. For the specific example, see this: https://github.com/bleroy/Nwazet.Commerce/compare/master...LaserSrl:Laser

I am trying to figure out a way around this, so that the project works in my system, but I can also push stuff and do PRs.

MatteoPiovanelli-Laser commented 7 years ago

This was fixed in #90