search

bleskodev / rubyripper

Fork of the original rubyripper from code.google.com/p/rubyripper + some bugs fixes
126 stars 21 forks source link

Ripping to Single File Forces Sox Usage for Pre-Emphasis #464

Open GoogleCodeExporter opened 8 years ago

GoogleCodeExporter commented 8 years ago 
1) Please describe the steps to reproduce the situation:
a. Enable "Generate Cue Sheet" and "Rip to Single File"
b. Insert disc with pre-emphasis.
c. Rip the disk.

2) What is the expected output? What do you see instead?
The GTK interface forces usage of Sox when 
I expect to be allowed a choice between Sox or having the pre-emphasis 
information written to the cue sheet per track.

3) What version of rubyripper are you using? On what operating system? The
gtk2 of commandline interface?
Rubyripper v0.6.0, Gentoo, GTK interface.

4) Is this not already fixed with the latest & greatest code? See for
instructions the Source tab above.
No it is not.

5) Does the problem happen with all discs? If not, please attach
the output of cdparanoia -Q with a disc that gives trouble.
Happens to all discs.

6) Please explain why this change is important for you. Also, how many
users would benefit from this change?
When doing CD archiving you should be ripping an exact copy of the disk and 
storing pre-emphasis information separately.

Please provide any additional information below. The more usefull
information provided, the sooner the issue will be fixed.
Attached is a patch to fix the issue.

Original issue reported on code.google.com by bluedrag...@gmail.com on 3 May 2011 at 5:06

GoogleCodeExporter commented 8 years ago 
I can confirm the issue. 

However, I noticed that the code that outputs "FLAGS PRE" to the cuesheet was 
also written in such a way that it would never be called for single-file rips. 
That makes me think this was maybe a deliberate design (but why?).

In any case, I'd like to append a second "patch", which just moves those lines 
of code to a different block. This should fix two things:

1) the FLAGS line now comes after the TRACK line, in closer compliance with the 
cdrwin "spec"

2) the FLAGS line may now get written for single-file rips

I have to put "patch" in quotes here, because I didn't manage to properly test 
it so far. I never touched any ruby before, and couldn't figure out yet how to 
feed test-tocs into these functions. I'm sending it to avoid it sitting on my 
disk for weeks. Apologies for the bad form!

Original comment by oei.yungchin@gmail.com on 30 May 2011 at 8:10

Attachments:

GoogleCodeExporter commented 8 years ago 
Thanks for that, I overlooked it. I've rolled these changed into my patch.

Original comment by bluedrag...@gmail.com on 30 May 2011 at 11:50

Attachments:

GoogleCodeExporter commented 8 years ago

Original comment by boukewou...@gmail.com on 9 Jan 2013 at 10:51