search

bleskodev / rubyripper

Fork of the original rubyripper from code.google.com/p/rubyripper + some bugs fixes
126 stars 21 forks source link

Cue sheet should contain ISRCs #506

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago 
1) Please describe the steps to reproduce the situation:
a. Rip including a cue sheet
b. Cue sheet does not include ISRC values found in the toc

2) What is the expected output? What do you see instead?
cdrdao extracts ISRC values when building a toc, ie here's an extract from Dire 
Straights "Brothers in Arms":
// Track 1
TRACK AUDIO
NO COPY
NO PRE_EMPHASIS
TWO_CHANNEL_AUDIO
ISRC "GBF088500673"
SILENCE 00:00:32
FILE "data.wav" 0 05:06:28
START 00:00:32

However, the CUE sheet that rubyripper generates does not contain it:
  TRACK 01 AUDIO
    TITLE "So Far Away"
    PERFORMER "Dire Straits"
    INDEX 00 00:00:00
    INDEX 01 00:00:32
Cue sheet syntax allows for the ISRC as a simple additional per-track element ( 
http://wiki.hydrogenaudio.org/index.php?title=Cue_sheet )

3) What version of rubyripper are you using? On what operating system? The
gtk2 of commandline interface?
0.6.2 on Debian Unstable with both GUI & CLI

4) Is this not already fixed with the latest & greatest code? See for
instructions the Source tab above.
I don't see anything in the latest git code that looks like it would address 
this

5) Does the problem happen with all discs? If not, please attach
the output of cdparanoia -Q with a disc that gives trouble.
Yes

6) Please explain why this change is important for you. Also, how many
users would benefit from this change?
When making images (ie, single file flac), as much metadata from the source as 
possible should be captured to get a complete backup.  Additionally, this 
information is useful to ie the Musicbrainz project so it would make it easier 
to capture this all in one step so it could be submitted later without 
re-querying the CD.

Please provide any additional information below. The more usefull
information provided, the sooner the issue will be fixed.

Original issue reported on code.google.com by snurgle@gmail.com on 17 Jan 2012 at 4:35

GoogleCodeExporter commented 8 years ago

Original comment by comradec...@gmail.com on 11 Feb 2012 at 6:57

GoogleCodeExporter commented 8 years ago 
Fixed with commit:
http://code.google.com/p/rubyripper/source/detail?r=808a9ae249a4543f7b58a7f6aab3
393e7312fd63

Original comment by boukewou...@gmail.com on 22 Oct 2012 at 6:53