bleskodev / rubyripper

Fork of the original rubyripper from code.google.com/p/rubyripper + some bugs fixes
126 stars 21 forks source link

Fetch CDDB tags only works after a couple of tries. #509

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
1) Please describe the steps to reproduce the situation:
a. Scan drive
b. Scan drive again
c. Scan drive a third time if second time did not do it

2) What is the expected output? What do you see instead?

A: I expect the fields to get filled in with the artist, song titles etc but 
instead I get CD query *something*... Return code not supported  a couple of 
times until it suddenly works.

3) What version of rubyripper are you using? On what operating system?

A: version 0.6.2 on Ubuntu 10.04.3 amd64/x64 using latest updates.

4) Is this not already fixed with the latest & greatest code? See for
instructions the Source tab above.

A: I can not answer that question, unfortunately.

5) Does the problem happen with all discs? If not, please attach
the output of cdparanoia -Q with a disc that gives trouble.

A: Yes it happens with all discs.

6) Please explain why this change is important for you. Also, how many
users would benefit from this change?

A: It would save me tons of time not having to fill in all values and I think 
probably every single Rubyripper user would benefit from it working.

Please provide any additional information below. The more usefull
information provided, the sooner the issue will be fixed.

A: Thank you for this application. Since going from Windows I have had a hard 
time finding applications to substitute EAC with. This might be a good choice 
though. Regards.

Original issue reported on code.google.com by icke...@gmail.com on 12 Feb 2012 at 10:39

GoogleCodeExporter commented 8 years ago
This is an issue with freedb currently.

Sometimes it will return "501 Invalid category: 'your discid'"
That gives you the Return code not supported <!D error

Sometimes it will return blank which will make all categories blank.

Sometimes it will work.

Rubyripper needs some error checking and looping on the return from freedb. I 
use the following with cddb-tool and bash.

export VAR=0
while [ $VAR -eq 0 ]
do
cddb-tool read $freedbserver 5 $cddbuser $cddbhost $genre $discid > discinfo
if grep DISCID discinfo
then VAR=1
else echo No Disc Info Found
sleep 3
fi
done

That will loop until it gets a valid response. 

To sum up, the issue is with freedb.
Rubyripper can compensate for freedb's failure with a bit of error checking.

I would submit a patch, but I don't know perl.

Original comment by sam...@yaple.net on 13 Feb 2012 at 4:59

GoogleCodeExporter commented 8 years ago
Too bad, would have been a nice feature for perlripper ;). On the serious side 
of life, is this issue already fixed on the freedb side?

Original comment by boukewou...@gmail.com on 14 Mar 2012 at 10:15

GoogleCodeExporter commented 8 years ago
I think it is a load issue on freeDB's side. I setup a local freeDB server and 
never had an issue after that. Going back to freeDB afterward I still had the 
issue intermittently. I wrote a simple script to pull the info and put it in 
rubyripper's local database before running the program.

Original comment by sam...@yaple.net on 12 Apr 2012 at 7:26

GoogleCodeExporter commented 8 years ago
I just revived the musicbrainz functionality in latest git. I suggest using 
this if the freedb server is not working reliable.

Original comment by boukewou...@gmail.com on 2 Dec 2012 at 12:35