bleskodev / rubyripper

Fork of the original rubyripper from code.google.com/p/rubyripper + some bugs fixes
126 stars 21 forks source link

Ripping fails using Finnish locale #511

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
1) Please describe the steps to reproduce the situation:
a. Try to rip
b. See it failing
c.

2) What is the expected output? What do you see instead?
Ripping to work. 

Actual output is: 
Ripping progress (0 %)
Ripping track 1
Expected filesize for track 1           is 204903932 bytes.
Free disk space is 88 MB
Not enough disk space left! Rip abortedRipping track 2
Expected filesize for track 2           is 199419068 bytes.
Free disk space is 88 MB
Not enough disk space left! Rip abortedRipping track 3
Expected filesize for track 3           is 29536460 bytes.
Free disk space is 88 MB
Not enough disk space left! Rip abortedRipping track 4
Expected filesize for track 4           is 33715964 bytes.
Free disk space is 88 MB
Not enough disk space left! Rip abortedroot@ran ~# rrip_cli 

3) What version of rubyripper are you using? On what operating system? The
gtk2 of commandline interface?
Stable version from git, 22.02.2012.

4) Is this not already fixed with the latest & greatest code? See for
instructions the Source tab above.
No idea, I weren’t able to make trunk to work when last tested. 

5) Does the problem happen with all discs? If not, please attach
the output of cdparanoia -Q with a disc that gives trouble.

6) Please explain why this change is important for you. Also, how many
users would benefit from this change?
Users not using English messages locale. 

Please provide any additional information below. The more usefull
information provided, the sooner the issue will be fixed.

I’m attaching a patch I made to go around this problem, for stable library. 

Original issue reported on code.google.com by samu.vou...@gmail.com on 22 Feb 2012 at 3:39

Attachments:

GoogleCodeExporter commented 8 years ago
Thanks for the patch :).

This is merged in the stable tree:
http://code.google.com/p/rubyripper/source/detail?r=4d119e1b00bd8897e70098c0b7d1
6a4ace61bfce&name=stable

And also in the master tree:
http://code.google.com/p/rubyripper/source/detail?r=d3414a68fbcf93b6b2d490e3d2ea
296fe84fbb99

Original comment by boukewou...@gmail.com on 29 Sep 2012 at 4:03