search

bleskodev / rubyripper

Fork of the original rubyripper from code.google.com/p/rubyripper + some bugs fixes
126 stars 21 forks source link

Crash on Special Characters in Track Names #571

Open GoogleCodeExporter opened 8 years ago

GoogleCodeExporter commented 8 years ago 
1) Please describe the steps to reproduce the situation:
a. Take a CD with Tracks with special Characters (e.g. German Umlauts)
b. Start Rip
c. Ruby Crashes

2) What is the expected output? What do you see instead?

No Crash 

3) What version of rubyripper are you using? On what operating system? The
gtk2 of commandline interface?

ArchLinux, latest Version of RubyRipper, gtk2.

4) Is this not already fixed with the latest & greatest code? See for
instructions the Source tab above.s.

Don't think so.

6) Please explain why this change is important for you. Also, how many
users would benefit from this change?

I have quite some CDs with german Umlauts as well as french characters.

I guess that the problem is the transformation of these special characters. The 
translation of these characters should be somewhat configurable, in that I 
would like to translate ä to ae, ü to ue and ö to oe ;-) Probably the french 
characters could be translated as well.

Original issue reported on code.google.com by markus...@gmail.com on 30 May 2013 at 8:07

GoogleCodeExporter commented 8 years ago 
I guess, that the method filter(item) in filterFiles.rb should be adopted, to 
support the functionality described in 
http://www.jroller.com/obie/tags/unicode. 

This provides a way to use a translation-table, which could be extended and to 
clean up filenames according to the filesystem standards of all systems (it 
should be ascii only IMHO, and also we should remove , and . from the real 
filename, because these suck).

What do you think?

Original comment by markus...@gmail.com on 10 Jun 2013 at 4:30

GoogleCodeExporter commented 8 years ago 
I don't think it shouldn't crash with special characters as long as the target 
filesystem supports UTF-8. This has always worked correctly as far as I know.

Original comment by boukewou...@gmail.com on 15 Jun 2013 at 2:36

GoogleCodeExporter commented 8 years ago 
This has certainly NOT always worked correctly. At least for me, 0.6.2 crashes 
if there are non-ASCII characters in the metadata. I'm not sure about the 
latest Git master.

Original comment by tuomo.le...@gmail.com on 19 Oct 2013 at 11:29

GoogleCodeExporter commented 8 years ago 
This seems to be a duplicate of 
http://code.google.com/p/rubyripper/issues/detail?id=449.

Original comment by tuomo.le...@gmail.com on 19 Oct 2013 at 3:43