bleskodev / rubyripper

Fork of the original rubyripper from code.google.com/p/rubyripper + some bugs fixes
126 stars 21 forks source link

Underscores in Filenaming scheme getting replaced with spaces #576

Open GoogleCodeExporter opened 8 years ago

GoogleCodeExporter commented 8 years ago
I'm using undercores within my filenaming scheme to divide fields. But I want 
spaces within the strings. so I don't want to replace spaces with underscores. 
But rubyripper seems to default to replace underscores with spaces.

1) Please describe the steps to reproduce the situation:
a. set the filenaming scheme to something like %a/%a_%y_%b/%n_%a_%t
b. rip a cd

2) What is the expected output? What do you see instead?

Expected output is:
$ ls -R Audioslave/
Audioslave/:
Audioslave_2006_Revelations

Audioslave/Audioslave_2006_Revelations:
01_Audioslave_Revelations.flac       04_Audioslave_Until we fall.flac  
07_Audioslave_Somedays.flac                 10_Audioslave_Wide awake.flac
02_Audioslave_One and the same.flac  05_Audioslave_Original fire.flac  
08_Audioslave_Shape of things to come.flac  11_Audioslave_Nothing left to say 
but goodbye.flac
03_Audioslave_Sound of a gun.flac    06_Audioslave_Broken city.flac    
09_Audioslave_Jewel of the summertime.flac  12_Audioslave_Moth.flac

Output is instead:
hmk@piledriver:~/music/flac$ ls -R Audioslave/
Audioslave/:
Audioslave 2006 Revelations

Audioslave/Audioslave 2006 Revelations:
01 Audioslave Revelations.flac       04 Audioslave Until we fall.flac  07 
Audioslave Somedays.flac                 10 Audioslave Wide awake.flac
02 Audioslave One and the same.flac  05 Audioslave Original fire.flac  08 
Audioslave Shape of things to come.flac  11 Audioslave Nothing left to say but 
goodbye.flac
03 Audioslave Sound of a gun.flac    06 Audioslave Broken city.flac    09 
Audioslave Jewel of the summertime.flac  12 Audioslave Moth.flac

3) What version of rubyripper are you using? On what operating system? The
gtk2 of commandline interface?

$ rrip_cli -V
ruby-gettext is not found. Translations are disabled!
Rubyripper version 0.6.2.

Debian-Package from deb-multimedia:
$ dpkg -s rubyripper
Package: rubyripper
Status: install ok installed
Priority: extra
Section: sound
Installed-Size: 572
Maintainer: Christian Marillat <marillat@deb-multimedia.org>
Bugs: mailto:marillat@deb-multimedia.org
Architecture: all
Version: 0.6.2-dmo1
Depends: ruby1.9.1, cdparanoia, libgtk2-ruby, eject
Recommends: normalize-audio, vorbisgain, mp3gain, flac, vorbis-tools
Suggests: lame, cd-discid
[...]

Operating system:
$ cat /etc/debian_version 
jessie/sid

$ uname -a
Linux xxx 3.9-1-amd64 #1 SMP Debian 3.9.8-1 x86_64 GNU/Linux

4) Is this not already fixed with the latest & greatest code? See for
instructions the Source tab above.

not checked

5) Does the problem happen with all discs? If not, please attach
the output of cdparanoia -Q with a disc that gives trouble.

Yes

6) Please explain why this change is important for you. Also, how many
users would benefit from this change?

This is a functional defect and therefore it should be fixed. All users would 
benefit from fix.

Original issue reported on code.google.com by henner.m...@gmail.com on 10 Aug 2013 at 9:09

GoogleCodeExporter commented 8 years ago
Confirm this issue on gentoo, package name/version 
media-sound/rubyripper-0.6.2-r1.

This is misclassified as an enhancement, it's a bug plain and simple.  The 
user's defined filenaming scheme should be reproduced literally 
(notwithstanding the variable expansions); if behaviour deviates from this, it 
should at the very least be documented.

Original comment by robin.ba...@gmail.com on 28 Dec 2013 at 3:30