bleskodev / rubyripper

Fork of the original rubyripper from code.google.com/p/rubyripper + some bugs fixes
126 stars 21 forks source link

Always get ID3v2.3, never ID3v2.4, even with just -V 0 setting #589

Open GoogleCodeExporter opened 8 years ago

GoogleCodeExporter commented 8 years ago
1) Please describe the steps to reproduce the situation:
a. Preferences => Codecs => Lame Mp3
b. -V 0
c. Rip cd now!

2) What is the expected output? What do you see instead?

Expect MP3 files with ID3v2.4 and ID3v1.1 tags.
What I see: MP3 files with ID3v2.3 and ID3v1.1 tags.

3) What version of rubyripper are you using? On what operating system? The
gtk2 or commandline interface?

Compiled from source 0.6.2 on Debian Wheezy. Using the gtk2 interface.

4) Is this not already fixed with the latest & greatest code? See for
instructions the Source tab above.

No.

5) Does the problem happen with all discs? If not, please attach
the output of cdparanoia -Q with a disc that gives trouble.

Happens with all discs.

6) Please explain why this change is important for you. Also, how many
users would benefit from this change?

In the past with other flavors of Linux and rubyripper, setting Lame Mp3 did 
this:

-V 0 resulted in ID3v2.4 and ID3v1.1 tags
-V 0 --id3v2-only resulted in ID3v2.3 only tags

This was valuable since sometimes I wanted ID3v2.4 and sometimes ID3v2.3.

Also, even though ID3v2.4 is not universally accepted, it is the current 
version and I feel that there should be a may for rubyripper to add these tags.

Please provide any additional information below. The more usefull
information provided, the sooner the issue will be fixed.

Note: I rip to flac and mp3 in the sames sessions -- I have tested this 
situation with and without flac at the same time and the resulting MP3 files 
are the same. 

If rubyripper is now writing only ID3v2.3 tags instead of ID3v2.4, that might 
be okay but I would like the documentation to reflect that fact.

Thank you,
Charles

Original issue reported on code.google.com by chass...@snet.net on 7 Feb 2014 at 3:23